Skip to content

Conversation

@jfschwarz
Copy link
Contributor

No description provided.

@jfschwarz jfschwarz changed the title Mark initialized Mark implementation contract initialized on deploy Feb 1, 2022
@auryn-macmillan
Copy link
Contributor

Rather than adding initializer to a constructor, we should have the constructor call initialize. This way users can choose to deploy this as a proxy or the full contract.

e.g.

constructor (address _owner,
    address _token,
    uint256 _depositDeadline,
    uint256 _lockDuration,
    string memory _name,
    string memory _symbol) {
  initialize(
    _owner,
    _token,
    _depositDeadline,
    _lockDuration,
    _name,
    _symbol
  );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants